| Summary: | [AppSSO] Correct logging messages to avoid confusing screeners that an error has occurred | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, pascoe, sacolo9459, simon.fraser, webkit-bug-importer, yivarak978 | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 453657 [details]
Patch
Committed r290758 (248002@main): <https://commits.webkit.org/248002@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453657 [details]. |
The phrasing of the message in 'SOAuthorizationCoordinator::tryAuthorize' when a URL is not relevant for AppSSO flows is: AUTHORIZATIONCOORDINATOR_RELEASE_LOG("tryAuthorize: Cannot authorize the requested URL."); This leads people spelunking logs to believe that the URL can't be authorized (perhaps due to an error). Instead, we should more accurately report that the URL is not one that is mediated through an AppSSO flow, and so no AppSSO processing is needed.