| Summary: | Update WPT css-scroll-snap tests | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||||||||||
| Component: | Tools / Tests | Assignee: | Martin Robinson <mrobinson> | ||||||||||||||
| Status: | REOPENED --- | ||||||||||||||||
| Severity: | Normal | CC: | clopez, ews-watchlist, jenner, rego, webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Martin Robinson
2022-03-02 01:45:48 PST
Created attachment 453582 [details]
Patch
Created attachment 453583 [details]
Patch
Created attachment 453584 [details]
Patch
Created attachment 453605 [details]
Patch
Comment on attachment 453605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453605&action=review r=me, please check that EWSs are green before landing. > LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-margin-005-expected.txt:1 > + I guess you miss a ChangeLog entry for this and next change. Created attachment 453606 [details]
Patch
Created attachment 453706 [details]
Patch
Committed r290774 (248018@main): <https://commits.webkit.org/248018@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453706 [details]. (In reply to EWS from comment #8) > Committed r290774 (248018@main): <https://commits.webkit.org/248018@main> > > All reviewed patches have been landed. Closing bug and clearing flags on > attachment 453706 [details]. This commit caused "imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-margin-005.html" to constantly fail on iOS: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-scroll-snap%2Fscroll-target-margin-005.html TEXT DIFF: -FAIL scroll-margin on input widget assert_between_exclusive: Should honor date input scroll-margin expected a number greater than 4750 and less than 4850 but got 9443 +FAIL scroll-margin on input widget assert_between_exclusive: Should honor date input scroll-margin expected a number greater than 4750 and less than 4850 but got 20000 DIFF URL: https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/r290839%20(1837)/imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-margin-005-pretty-diff.html This test started to fail as soon as it was enabled in r290774. Instead of reverting that commit, I have instead marked the test as failing here, since is was slowing down EWS results: https://commits.webkit.org/248084@main I am re-opening this bug so this test failure can be worked on. |