| Summary: | Add test coverage for deleting FileSystem data when file is being written | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||
| Component: | Tools / Tests | Assignee: | Sihui Liu <sihui_liu> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sihui Liu
2022-03-01 22:53:44 PST
Created attachment 453572 [details]
Patch
Comment on attachment 453572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453572&action=review > Tools/ChangeLog:8 > + Verify that file can be removed from disk, and active FileSystemSyncAccessHandle is invalidated in ths case. Typo: "ths" > Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:208 > + RetainPtr<NSData> data; Why declare the variable here? > Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:212 > + data = [NSData dataWithBytes:workerBytes length:strlen(workerBytes)]; RetainPtr data = [NSData dataWithBytes:workerBytes length:strlen(workerBytes)]; Comment on attachment 453572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453572&action=review >> Tools/ChangeLog:8 >> + Verify that file can be removed from disk, and active FileSystemSyncAccessHandle is invalidated in ths case. > > Typo: "ths" Will change. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:212 >> + data = [NSData dataWithBytes:workerBytes length:strlen(workerBytes)]; > > RetainPtr data = [NSData dataWithBytes:workerBytes length:strlen(workerBytes)]; Sure, will change. Created attachment 453628 [details]
Patch for landing
Created attachment 453629 [details]
Patch for landing
Committed r290736 (247983@main): <https://commits.webkit.org/247983@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453629 [details]. |