Bug 237349

Summary: AX: Handle null FileList in RenderFileUploadControl::fileTextValue()
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: andresg_22, cdumez, cfleizach, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mifenton, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tyler Wilcock 2022-03-01 17:13:00 PST 
In rare circumstances, it's possible for the FileList associated with RenderFileUploadControl::inputElement (HTMLInputElement::files()) to be null. We should avoid crashing in these scenarios.
Comment 1 Radar WebKit Bug Importer 2022-03-01 17:13:12 PST 
<rdar://problem/89651456>
Comment 2 Tyler Wilcock 2022-03-01 17:47:57 PST 
Created attachment 453555 [details]
Patch
Comment 3 chris fleizach 2022-03-01 17:56:56 PST 
Comment on attachment 453555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453555&action=review

> Source/WebCore/rendering/RenderFileUploadControl.cpp:261
> +        return String();

return { };
Comment 4 Tyler Wilcock 2022-03-01 18:18:19 PST 
Created attachment 453559 [details]
Patch
Comment 5 Tyler Wilcock 2022-03-01 18:19:20 PST 
> > Source/WebCore/rendering/RenderFileUploadControl.cpp:261
> > +        return String();
> 
> return { };
Fixed.
Comment 6 EWS 2022-03-02 10:55:13 PST 
Committed r290738 (247984@main): <https://commits.webkit.org/247984@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453559 [details].