Bug 237346

Summary: REGRESSION(r290539): [ iOS ] 2X http/wpt/webauthn/public-key-credential-create-failure-local (layout-tests) are constant text failures
Product: WebKit Reporter: Robert Jenner <jenner>
Component: WebKit Misc.Assignee: pascoe <pascoe>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, Morningstar, pascoe, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237548    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Robert Jenner 2022-03-01 16:02:02 PST 
The following two http/wpt/webauthn/public-key-credential-create-failure-local layout-tests are constant text failures on iOS. 

http/wpt/webauthn/public-key-credential-create-failure-local.https.html
http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=http%2Fwpt%2Fwebauthn%2Fpublic-key-credential-create-failure-local-silent.https.html&test=http%2Fwpt%2Fwebauthn%2Fpublic-key-credential-create-failure-local.https.html

The diff appears to be the same for both tests. 

TEXT DIFF:
 PASS PublicKeyCredential's [[create]] with matched exclude credentials in a mock local authenticator. 2nd
 PASS PublicKeyCredential's [[create]] without user consent in a mock local authenticator.
 PASS PublicKeyCredential's [[create]] without private keys in a mock local authenticator.
-PASS PublicKeyCredential's [[create]] without attestation in a mock local authenticator.
+FAIL PublicKeyCredential's [[create]] without attestation in a mock local authenticator. assert_unreached: Should have rejected: Couldn't attest: The operation couldn't complete. Reached unreachable code. 

DIFF URLS:
https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/r290667%20(1795)/http/wpt/webauthn/public-key-credential-create-failure-local.https-pretty-diff.html
https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/r290667%20(1795)/http/wpt/webauthn/public-key-credential-create-failure-local-silent.https-pretty-diff.html
Comment 1 Radar WebKit Bug Importer 2022-03-01 16:02:40 PST 
<rdar://problem/89647260>
Comment 2 Dawn Morningstar 2022-03-01 16:14:19 PST 
My bug https://bugs.webkit.org/show_bug.cgi?id=237345 is the same as this one, but this one includes the second test so I am marking mine as a duplicate.
Comment 3 pascoe@apple.com 2022-03-01 16:14:53 PST 
Created attachment 453546 [details]
Patch
Comment 4 Dawn Morningstar 2022-03-01 16:15:06 PST 
*** Bug 237345 has been marked as a duplicate of this bug. ***
Comment 5 Brent Fulgham 2022-03-02 10:19:34 PST 
Comment on attachment 453546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453546&action=review

r=me

> LayoutTests/ChangeLog:10
> +        we've changed behavior such that creation still succeeds with none attestation

Nit: Maybe say: "... succeeds with 'none' attestation in this case..."
Comment 6 pascoe@apple.com 2022-03-02 11:00:17 PST 
Created attachment 453637 [details]
Patch for landing
Comment 7 EWS 2022-03-02 13:05:34 PST 
Committed r290751 (247995@main): <https://commits.webkit.org/247995@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453637 [details].
Comment 8 Dawn Morningstar 2022-03-07 11:28:59 PST 
http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html and
http/wpt/webauthn/public-key-credential-create-failure-local.https.html 

Still appear to be constantly failing.