Bug 237318

Summary: Remove RemoteVideoSample support from ImageTransferSessionVT
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

youenn fablet
Reported 2022-03-01 04:14:01 PST
Remove RemoteVideoSample support from ImageTransferSessionVT
Attachments
Patch (13.80 KB, patch)
2022-03-01 04:17 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (13.76 KB, patch)
2022-03-01 04:22 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (13.19 KB, patch)
2022-03-01 05:00 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-03-01 04:17:33 PST
Created attachment 453489 [details] Patch
youenn fablet
Comment 2 2022-03-01 04:22:02 PST
Created attachment 453490 [details] Patch
youenn fablet
Comment 3 2022-03-01 05:00:29 PST
Created attachment 453491 [details] Patch
Eric Carlson
Comment 4 2022-03-01 09:16:11 PST
Comment on attachment 453491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453491&action=review > Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.cpp:269 > + auto videoFrame = MediaSampleAVFObjC::createImageSample(WTFMove(pixelBuffer), remoteSample.rotation(), remoteSample.mirrored(), remoteSample.time()); As a followup, I think `MediaSampleAVFObjC::createImageSample` is a slightly confusing name. Maybe something like `MediaSampleAVFObjC::createFromPixelBuffer` would be clearer?
EWS
Comment 5 2022-03-01 23:09:31 PST
Committed r290721 (247968@main): <https://commits.webkit.org/247968@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453491 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-01 23:10:18 PST
<rdar://problem/89667765>
Note You need to log in before you can comment on or make changes to this bug.