Bug 237316

<rdar://problem/89959777>

Created attachment 454328 [details]
Patch

Created attachment 454330 [details]
Patch

Created attachment 454334 [details]
Patch

Created attachment 454338 [details]
Patch

Comment on attachment 454338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454338&action=review

> Source/WebKit/ChangeLog:11
> +        Since display tracks are already cloned remotely, we can merge RemoteRealtimeDisplaySource and RemoteRealtimeVideoSource.

This is great!

> Source/WebCore/platform/mediastream/RealtimeMediaSource.h:265
>      virtual void startProducingData() { }
>      virtual void stopProducingData() { }
> +    virtual void endProducingData() { stop(); }

I think it will be easy for someone that doesn't already know how these classes work to be confused about the difference between stopProducingData and endProducingData.

Conceptually these methods start, pause, and stop  (or cancel?) capture, so maybe they could be `startProducingData`, `pauseProducingData`, and `stopProducingData`. Or maybe we should change all three: `startDataProduction`, `pauseDataProduction`, and `endDataProduction`?

Renaming will touch a lot of files so it could be done in another patch

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:-4186
> -		418FCBE3271049DB00F96ECA /* RemoteRealtimeDisplaySource.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = RemoteRealtimeDisplaySource.cpp; sourceTree = "<group>"; };
> -		418FCBE4271049DC00F96ECA /* RemoteRealtimeDisplaySource.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RemoteRealtimeDisplaySource.h; sourceTree = "<group>"; };

Can these files be deleted now?

(In reply to Eric Carlson from comment #6)
> Comment on attachment 454338 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454338&action=review
> 
> > Source/WebKit/ChangeLog:11
> > +        Since display tracks are already cloned remotely, we can merge RemoteRealtimeDisplaySource and RemoteRealtimeVideoSource.
> 
> This is great!

Glad you like it, I think it will make things simpler indeed.
Next step is to make RemoteRealtimeAudioSource and RemoteRealtimeVideoSource share most of the code in RemoteRealtimeMediaSource.

> > Source/WebCore/platform/mediastream/RealtimeMediaSource.h:265
> >      virtual void startProducingData() { }
> >      virtual void stopProducingData() { }
> > +    virtual void endProducingData() { stop(); }
> 
> I think it will be easy for someone that doesn't already know how these
> classes work to be confused about the difference between stopProducingData
> and endProducingData.
> 
> Conceptually these methods start, pause, and stop  (or cancel?) capture, so
> maybe they could be `startProducingData`, `pauseProducingData`, and
> `stopProducingData`. Or maybe we should change all three:
> `startDataProduction`, `pauseDataProduction`, and `endDataProduction`?

Agreed.
start and stop are not terminal while end is stop+cannot start again.
I guess we could use pause/resume/end?

> Renaming will touch a lot of files so it could be done in another patch
> 
> > Source/WebKit/WebKit.xcodeproj/project.pbxproj:-4186
> > -		418FCBE3271049DB00F96ECA /* RemoteRealtimeDisplaySource.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = RemoteRealtimeDisplaySource.cpp; sourceTree = "<group>"; };
> > -		418FCBE4271049DC00F96ECA /* RemoteRealtimeDisplaySource.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RemoteRealtimeDisplaySource.h; sourceTree = "<group>"; };
> 
> Can these files be deleted now?

Will do.

Created attachment 454466 [details]
Patch for landing

Committed r291167 (248327@main): <https://commits.webkit.org/248327@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454466 [details].