Bug 237275

Summary:

Misc compiler warnings, late Feb 2022 edition

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebKit Misc.

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, bugs-noreply, mcatanzaro, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Michael Catanzaro

Reported 2022-02-28 08:51:16 PST

Let's fix a bunch of GCC warnings.

Attachments
Patch (14.77 KB, patch) 2022-02-28 08:56 PST, Michael Catanzaro	no flags	Details Formatted Diff Diff
Patch for landing (10.76 KB, patch) 2022-03-01 14:12 PST, Michael Catanzaro	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2022-02-28 08:56:36 PST

Created attachment 453394 [details] Patch

Adrian Perez

Comment 2 2022-02-28 13:51:37 PST

Comment on attachment 453394 [details] Patch I am not sure about changing the GStreamer version checks; the rest of the cleanups LGTM. View in context: https://bugs.webkit.org/attachment.cgi?id=453394&action=review > Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:261 > +#if GST_CHECK_VERSION(1, 19, 2) I think it would be in the interest of Fedora users that the distribution starts shipping the stable 1.20.0 release instead of lowering the check here in WebKit code. These were explicitly changed to check for 1.20.0 in r289154 so I expect there is some actual reason for that — other times we have left version checks for release candidates in the code knowingly.

Michael Catanzaro

Comment 3 2022-02-28 14:48:44 PST

(In reply to Adrian Perez from comment #2) > I think it would be in the interest of Fedora users that the distribution > starts > shipping the stable 1.20.0 release instead of lowering the check here in > WebKit > code. OK, it's a Fedora screw-up for sure. Will remove those before landing, setting cq- as a reminder for myself. > These were explicitly changed to check for 1.20.0 in r289154 so I > expect > there is some actual reason for that — other times we have left version > checks > for release candidates in the code knowingly. I think it's just a choice of style. I'd say it looks slightly nicer to use guards for stable versions, assuming you are OK with not supporting the relevant unstable versions.

Adrian Perez

Comment 4 2022-03-01 13:36:10 PST

Comment on attachment 453394 [details] Patch r=me, with the change that will leave the GStreamer conditionals as they are in trunk at the moment :)

Michael Catanzaro

Comment 5 2022-03-01 14:12:06 PST

Created attachment 453540 [details] Patch for landing

EWS

Comment 6 2022-03-01 15:36:41 PST

Committed r290681 (247952@main): <https://commits.webkit.org/247952@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453540 [details].

Radar WebKit Bug Importer

Comment 7 2022-03-01 15:37:18 PST

<rdar://problem/89645743>

Note You need to log in before you can comment on or make changes to this bug.