| Summary: | Introduce routines to exchange SharedVideoFrame::Buffer directly | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
youenn fablet
2022-02-27 23:45:18 PST
Created attachment 453371 [details]
Patch
Created attachment 453375 [details]
Patch
Created attachment 453488 [details]
Patch
Created attachment 453497 [details]
Patch
Ping review. Comment on attachment 453497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453497&action=review > Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:109 > + auto videoFrame = get(WTFMove(read)); Obviously this isn't new to this patch, but reading this made me realize that RemoteVideoFrameObjectHeap::get is a confusing name because `get` RefPtr::get and Ref::get are so widely used in WebKit and don't mean the same thing at all. > Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:248 > + m_videoFrameObjectHeap->get(WTFMove(std::get<RemoteVideoFrameReadReference>(sharedVideoFrame.buffer))); Ditto. Created attachment 453718 [details]
Patch for landing
Committed r290824 (248060@main): <https://commits.webkit.org/248060@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453718 [details]. |