Bug 237237

Summary:

Fix deprecations for ERB.new in GenerateSettings.rb

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Tools / Tests

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Hironori.Fujii, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=237035
https://bugs.webkit.org/show_bug.cgi?id=236684

Attachments:

Description	Flags
Patch	none

Description Don Olmstead 2022-02-26 08:11:12 PST

C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
C:/webkit/Source/WebCore/Scripts/GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

Comment 1 Fujii Hironori 2022-02-27 12:00:21 PST

Thank you for bug reporting. This issue was fixded by r290104. Please try the latest.

*** This bug has been marked as a duplicate of bug 236684 ***

Comment 2 Don Olmstead 2022-02-27 22:52:04 PST

This is for GenerateSettings.rb while the bug you marked is for GeneratePreferences.rb

Comment 3 Fujii Hironori 2022-03-01 15:56:34 PST

Oops. It's my mistake. Will fix.

Comment 4 Fujii Hironori 2022-03-01 16:36:49 PST

Created attachment 453548 [details]
Patch

Comment 5 Don Olmstead 2022-03-01 16:38:55 PST

Comment on attachment 453548 [details]
Patch

r=me assuming bots are happy

Comment 6 EWS 2022-03-01 22:04:27 PST

Committed r290718 (247965@main): <https://commits.webkit.org/247965@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453548 [details].

Comment 7 Radar WebKit Bug Importer 2022-03-01 22:05:19 PST

<rdar://problem/89665192>