Bug 237231

Summary: Drop Ref<>'s operator==() as it is a bit ambiguous / confusing
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cmarcelo, darin, dino, eric.carlson, ews-watchlist, fmalita, ggaren, glenn, gyuyoung.kim, hta, jer.noble, kondapallykalyan, pdr, philipj, sabouhallawa, sam, schenney, sergio, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Description Chris Dumez 2022-02-25 16:16:21 PST 
Drop Ref<>'s operator==() as it is a bit ambiguous / confusing. Some people expect it to compare pointers while other expect it to compare the values we hold references to.
It seems best to omit this operator and be explicit at call sites.
Comment 1 Chris Dumez 2022-02-25 16:49:45 PST 
Created attachment 453276 [details]
Patch
Comment 2 Chris Dumez 2022-02-25 16:59:19 PST 
Created attachment 453277 [details]
Patch
Comment 3 EWS 2022-02-26 15:38:09 PST 
Committed r290552 (247830@main): <https://commits.webkit.org/247830@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453277 [details].
Comment 4 Radar WebKit Bug Importer 2022-02-26 15:39:19 PST 
<rdar://problem/89518176>