Bug 237213

Summary:	CSSStyleDeclaration+PropertyNames.idl: 1 input keys have identical hash values, examine output carefully...
Product:	WebKit	Reporter:	Michael Catanzaro <mcatanzaro>
Component:	CSS	Assignee:	Dan Glastonbury <djg>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, berto, cdumez, cgarcia, darin, gsnedders, koivisto, mcatanzaro, sam, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	All
OS:	All

Description Michael Catanzaro 2022-02-25 09:23:44 PST

We should figure out what is going wrong with CSSStyleDeclaration+PropertyNames.idl:

[327/2481] Generating ../../WebCore/DerivedSources/CSSProp...bCore/DerivedSources/CSSStyleDeclaration+PropertyNames.idl
1 input keys have identical hash values, examine output carefully...

Comment 1 Michael Catanzaro 2022-02-25 09:28:29 PST

The generated file says:

// This file is automatically generated from CSSProperties.json by the makeprop.pl script. Do not edit it.

However, we have no clear way to know what "input keys" are problematic here. I've failed to even find the source of this warning. We don't appear to have the strings "identical hash values" or "examine output carefully" anywhere in WebKit, nor even anywhere in Debian (I tried codesearch.debian.net), so it is unclear where this warning is coming from.

Comment 2 Sam Sneddon [:gsnedders] 2022-02-25 09:52:31 PST

My guess would be that it's from gperf, but I haven't looked into this.

Comment 3 Radar WebKit Bug Importer 2022-02-25 09:53:14 PST

<rdar://problem/89479324>

Comment 4 Alexey Proskuryakov 2022-10-07 11:58:29 PDT

Somewhat long shot, but any chance for bug 245803 to be caused by this? If so, this seems seriously bad, as it changes observable behavior.

I have no idea about how to "examine output carefully" here.

Comment 5 Michael Catanzaro 2022-10-07 14:02:32 PDT

The output files are:

${WebCore_DERIVED_SOURCES_DIR}/CSSProperties.json
${WebCore_DERIVED_SOURCES_DIR}/CSSPropertyNames.h
${WebCore_DERIVED_SOURCES_DIR}/CSSPropertyNames.cpp
${WebCore_DERIVED_SOURCES_DIR}/CSSPropertyNames.gperf
${WebCore_DERIVED_SOURCES_DIR}/StyleBuilderGenerated.cpp
${WebCore_DERIVED_SOURCES_DIR}/StylePropertyShorthandFunctions.h
${WebCore_DERIVED_SOURCES_DIR}/StylePropertyShorthandFunctions.cpp
${WebCore_DERIVED_SOURCES_DIR}/CSSStyleDeclaration+PropertyNames.idl

Of which CSSStyleDeclaration+PropertyNames.idl might possibly be related to bug #245803.

Comment 6 Sam Sneddon [:gsnedders] 2022-10-07 21:07:01 PDT

(In reply to Michael Catanzaro from comment #1)
> The generated file says:
> 
> // This file is automatically generated from CSSProperties.json by the
> makeprop.pl script. Do not edit it.
> 
> However, we have no clear way to know what "input keys" are problematic
> here. I've failed to even find the source of this warning. We don't appear
> to have the strings "identical hash values" or "examine output carefully"
> anywhere in WebKit, nor even anywhere in Debian (I tried
> codesearch.debian.net), so it is unclear where this warning is coming from.

https://git.savannah.gnu.org/gitweb/?p=gperf.git;a=blob;f=src/search.cc;h=c2459701036d3f7e2dbd35f78fc8d6168c2bd7e6;hb=refs/tags/v3.0.3#l796

Comment 7 Dan Glastonbury 2022-10-15 01:57:55 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5415

Comment 8 EWS 2022-10-15 07:31:48 PDT

Committed 255578@main (bd3be165cd17): <https://commits.webkit.org/255578@main>

Reviewed commits have been landed. Closing PR #5415 and removing active labels.