| Summary: | RemoteVideoFrameObjectHeap should process its IPC messages in a background thread | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, glenn, hi, jer.noble, joepeck, kkinnunen, pangle, philipj, sergio, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 237191 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2022-02-25 04:25:46 PST
Created attachment 453196 [details]
Patch
Comment on attachment 453196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453196&action=review > Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:47 > + static auto& queue = WorkQueue::create("org.webkit.RemoteVideoFrameObjectHeap", WorkQueue::QOS::UserInteractive).leakRef(); > + return queue; In newer code we’ve been using NeverDestroyed rather than leakRef for cases like this. More like this: static NeverDestroyed queue = WorkQueue::create("org.webkit.RemoteVideoFrameObjectHeap", WorkQueue::QOS::UserInteractive; return queue; Should be the same generated code. Created attachment 453343 [details]
Patch for landing
Created attachment 453369 [details]
Patch for landing
Committed r290591 (247869@main): <https://commits.webkit.org/247869@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453369 [details]. |