| Summary: | [GTK] The setting WebKitMinimumFontSize is not reset by the testing framework, leading to flaky tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Arcady Goldmints-Orlov <crzwdjk> | ||||||
| Component: | Tools / Tests | Assignee: | Arcady Goldmints-Orlov <crzwdjk> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, changseok, lmoura, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
|
Description
Arcady Goldmints-Orlov
2022-02-24 20:28:58 PST
(In reply to Arcady Goldmints-Orlov from comment #0) > The test fast/forms/validation-message-minimum-font-size.html uses the > setting WebKitMinimumFontSize, which on GTK does not appear to be getting > reset between tests, leading to failures in tests that run in the same test > runner process, which results in test flakiness. The code to set this > setting on GTK was introduced by r288666. May I ask what tests are flaky in particular? If you are looking to reproduce it, the command I have been using is: Tools/Scripts/run-webkit-tests --no-new --child-processes=1 --no-show fast/forms/validation-message-minimum-font-size.html fast/text/international (In reply to Arcady Goldmints-Orlov from comment #2) > If you are looking to reproduce it, the command I have been using is: > > Tools/Scripts/run-webkit-tests --no-new --child-processes=1 --no-show > fast/forms/validation-message-minimum-font-size.html fast/text/international Unfortunately, I could not reproduce the issue in two different Linux distributions: Ubuntu 21.10 and Fedora 35. In my investigation, a WebPreferences instance is ephemeral so each test creates its own WebPreferences rather than sharing one among tests. Would you test if the attached hotfix resolves your issue? Created attachment 456521 [details]
A hotfix
This was fixed by r292681, I will remove the line from the TestExpectation. Created attachment 458455 [details]
[fast-cq] Patch
Committed r293523 (250054@main): <https://commits.webkit.org/250054@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458455 [details]. |