| Summary: | Refactor logic for showing "Markup Image" and Quick Note items in the callout bar | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | Platform | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | akeerthi, hi, katherine_cheney, megan_gardner, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2022-02-23 20:48:17 PST
Created attachment 453068 [details]
For EWS
Comment on attachment 453068 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=453068&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:96 > + EXPECT_FALSE([menuBuilder containsActionWithTitle:WebCore::contextMenuItemTagAddHighlightToNewQuickNote()]); You should still test for both App Highlight menu items. If things change around the logic for which item to show when, it's unlikely that this test would be updated as a part of that. So, best to just do it now. > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:104 > + EXPECT_TRUE([menuBuilder containsActionWithTitle:WebCore::contextMenuItemTagAddHighlightToNewQuickNote()]); ditto. Comment on attachment 453068 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=453068&action=review Thanks for the review! >> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:96 >> + EXPECT_FALSE([menuBuilder containsActionWithTitle:WebCore::contextMenuItemTagAddHighlightToNewQuickNote()]); > > You should still test for both App Highlight menu items. If things change around the logic for which item to show when, it's unlikely that this test would be updated as a part of that. So, best to just do it now. Sounds good — I'll add checks to verify that the "Add to existing Quick Note" items are not also present in either case. Created attachment 453109 [details]
For landing
Committed r290450 (247752@main): <https://commits.webkit.org/247752@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453109 [details]. |