Bug 237090

Summary: [IFC][Integration] LineLayout::firstLinePhysicalBaseline/lastLineLogicalBaseline should flip box baseline value for vertical-lr
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

alan
Reported 2022-02-23 09:38:18 PST
ssia
Attachments
Patch (4.25 KB, patch)
2022-02-23 09:39 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-02-23 09:39:29 PST
Created attachment 452992 [details] Patch
Antti Koivisto
Comment 2 2022-02-23 09:46:14 PST
Comment on attachment 452992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452992&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:466 > + switch (rootLayoutBox().style().writingMode()) { > + case WritingMode::TopToBottom: wonder if the switch could be usefully shared between first/last cases?
alan
Comment 3 2022-02-23 09:53:26 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 452992 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452992&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:466 > > + switch (rootLayoutBox().style().writingMode()) { > > + case WritingMode::TopToBottom: > > wonder if the switch could be usefully shared between first/last cases? I'd rather not mix logical and physical translates (the first baseline API returns physical while the last baseline API returns logical baseline value)
EWS
Comment 4 2022-02-23 12:35:21 PST
Committed r290388 (247703@main): <https://commits.webkit.org/247703@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452992 [details].
Radar WebKit Bug Importer
Comment 5 2022-02-23 12:36:16 PST
<rdar://problem/89372080>
Note You need to log in before you can comment on or make changes to this bug.