Bug 237056
| Summary: | git-webkit pr tried to create another commit from local changes on current branch | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | ASSIGNED | ||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Aakash Jain
I was on a branch, made a commit to it. I also had some local changes in other files. When I run git-webkit pr command, it automatically tried to create another commit from local changes. This might be unexpected for users, especially when they explicitly committed what they wanted to commit/push. Coupled with the fact that git-webkit pr doesn't show any preview before creating the PR, this might not be a good idea.
git-webkit pr shouldn't try to automatically commit local changes when user is on a branch and there is already a commit by the user on that branch. Either errroring out or asking the user if he/she wants to create a commit from local changes is better.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Jonathan Bedard
This is deliberate behavior, and aligns with what `webkit-patch` does. No particularly hard to change, but we need a larger discussion because my understand is that folks migrating from SVN largely find this behavior desirable.
Radar WebKit Bug Importer
<rdar://problem/89638850>