| Summary: | Share more code between dispatchSessionStorageEvents() and dispatchLocalStorageEvents() | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, darin, ggaren, sihui_liu, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=236985 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Chris Dumez
2022-02-22 08:10:58 PST
Created attachment 452872 [details]
Patch
Created attachment 452889 [details]
Patch
Created attachment 452891 [details]
Patch
Comment on attachment 452891 [details]
Patch
r=me
Comment on attachment 452891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452891&action=review > Source/WebCore/storage/StorageEventDispatcher.cpp:52 > + if (!isRelevantPage(window.page())) Love this the way it is already, but one note: Could put the null check in the shared code and pass a Page& to the function. Created attachment 452911 [details]
Patch
Committed r290342 (247662@main): <https://commits.webkit.org/247662@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452911 [details]. |