Bug 237029

Summary:

[WASM-GC] Introduce structs types

Product:

WebKit

Reporter:

Dmitry <dbezhetskov>

Component:

New Bugs

Assignee:

Dmitry <dbezhetskov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

247394

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Description Dmitry 2022-02-22 03:41:10 PST

[WASM-GC] WIP: introduce structs

Comment 1 Dmitry 2022-02-22 03:48:16 PST

Created attachment 452850 [details]
Patch

Comment 2 EWS Watchlist 2022-02-22 03:49:54 PST

This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".

Comment 3 Radar WebKit Bug Importer 2022-03-01 03:42:18 PST

<rdar://problem/89611482>

Comment 4 Saam Barati 2022-03-01 10:53:06 PST

Comment on attachment 452850 [details]
Patch

This approach looks good to me. Not sure if you meant to set r?

Comment 5 Dmitry 2022-03-02 02:37:44 PST

I've set the r?

Comment 6 Keith Miller 2022-03-10 07:53:27 PST

Comment on attachment 452850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452850&action=review

r=me, should we rename the Signature class to something else. I worry that we’re somewhat misusing that term from classical its classical meaning.

> Source/JavaScriptCore/wasm/WasmLimits.h:47
> +constexpr size_t maxStructFieldCount = 1000000;

That’s a huge number, can we handle things that large? Is that the spec limit?

> Source/JavaScriptCore/wasm/WasmSectionParser.cpp:61
> +                return fail(i, "th struct types are not enabled");

Nit: Maybe “th type failed to parse…”, or does ‘fail’ say what section we are in?

Comment 7 Dmitry 2022-03-30 09:22:19 PDT

Created attachment 456130 [details]
Patch

Comment 8 Dmitry 2022-03-30 21:52:29 PDT

Reduced maxStructFieldCount, it is not a spec limit so imho 10000 is enough.
Also fixed the error message for section parser.

Comment 9 Dmitry 2022-03-31 23:57:37 PDT

Created attachment 456328 [details]
Patch

Comment 10 Dmitry 2022-04-03 00:45:55 PDT

Created attachment 456503 [details]
Patch

Comment 11 Dmitry 2022-04-07 04:11:18 PDT

Created attachment 456905 [details]
Patch

Comment 12 EWS 2022-04-12 09:05:03 PDT

Committed r292773 (249557@main): <https://commits.webkit.org/249557@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456905 [details].