Bug 237026

Summary: WTF::ThreadAssertion is not useful as most of the code is run with a WorkQueue
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: Web Template FrameworkAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 236832    
Bug Blocks:    

Description Kimmo Kinnunen 2022-02-22 01:40:28 PST 
WTF::ThreadAssertion is not useful as most of the code is run with a WorkQueue

ThreadAssertion cannot be used with WorkQueues because a WorkQueue might run its runnables in multiple different threads. On Cocoa this happens via thread of a thread pool for Dispatch dispatch queue.

We should have an assertion that can assert that the object is manipulated in the expected sequence, where sequence means either work queue or thread.
Comment 1 Radar WebKit Bug Importer 2022-03-01 01:41:15 PST 
<rdar://problem/89608226>
Comment 2 Kimmo Kinnunen 2022-10-04 03:32:45 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4974
Comment 3 Kimmo Kinnunen 2022-10-05 02:19:15 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5020
Comment 4 EWS 2022-10-07 09:26:17 PDT 
Committed 255274@main (8ed46d3dd638): <https://commits.webkit.org/255274@main>

Reviewed commits have been landed. Closing PR #5020 and removing active labels.