Bug 236976

Summary: Ensure generated inline assembler that setups segments returns to previous state
Product: WebKit Reporter: Adrian Perez <aperez>
Component: JavaScriptCoreAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236506
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2022-02-21 08:00:41 PST
After fixing bug #236506 there are still a few locations which make use of inline assembler in C++ code explicitly setting the segment where to emit output without returning the assembler to its previous state. Let's get them fixed as well!
Attachments
Patch (3.18 KB, patch)
2022-02-21 08:03 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2022-02-21 08:03:52 PST
Created attachment 452735 [details] Patch
Yusuke Suzuki
Comment 2 2022-02-21 14:28:50 PST
Comment on attachment 452735 [details] Patch r=me
EWS
Comment 3 2022-02-23 01:29:58 PST
Committed r290359 (247677@main): <https://commits.webkit.org/247677@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452735 [details].
Radar WebKit Bug Importer
Comment 4 2022-02-23 01:30:23 PST
<rdar://problem/89343981>
Note You need to log in before you can comment on or make changes to this bug.