Bug 236930

Summary:

[GPU Process] Tests with untriaged flaky crashes

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

WebKit Process Model

Assignee:

Cameron McCormack (:heycam) <heycam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

heycam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=236685

Bug Depends on:

Bug Blocks:

233914

Attachments:

Description	Flags
Patch	none

Description Jon Lee 2022-02-19 22:12:36 PST

accessibility/ios-simulator/aria-details.html [ Crash Pass ]
ddcss3/images/cross-fade-simple.html [ Crash Pass ]
webkit.org/b/236794 editing/spelling/editing-word-with-marker-2.html [ Crash Pass ]
fast/backgrounds/background-fast-path-simple-color.html [ Crash Pass ]
fast/backgrounds/background-clip-text-on-body.html [ Crash Pass ]
fast/backgrounds/background-clip-text-with-simple-container.html [ Crash Pass ]
fast/backgrounds/background-clip-text.html [ Crash Pass ]
fast/clip/clip-hit-null-iterator-path-comparison.html [ Crash Pass ]
fast/clip/clip-when-rect-has-fractional-pixel-value.html [ Crash ImageOnlyFailure ]
fast/css/clip-zooming.html [ Crash Pass ]
fast/hidpi/clip-text-in-hidpi.html [ Crash Pass ]
fast/mediastream/captureStream/canvas2d-heavy-drawing.html [ Crash Pass ]
imported/blink/fast/backgrounds/bug420029.html [ Crash Pass ]
imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-popup-behavior.html [ Crash Pass ]
imported/w3c/web-platform-tests/html/cross-origin-opener-policy/historical/popup-same-origin-unsafe-allow-outgoing-with-cross-origin.https.html [ Crash Pass ]
imported/w3c/web-platform-tests/html/dom/historical.html [ Crash Pass ]
imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html [ Crash Pass ]
imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html [ Crash Pass ]
imported/w3c/web-platform-tests/shadow-dom/Element-interface-attachShadow.html [ Crash Pass ]
imported/w3c/web-platform-tests/webstorage/storage_session_window_open.window.html [ Crash Pass ]

Comment 1 Radar WebKit Bug Importer 2022-02-19 22:12:58 PST

<rdar://problem/89196929>

Comment 2 Jon Lee 2022-02-21 17:53:40 PST

fast/css/clip-text-in-scaled-div.html [ Crash Pass ]

Comment 3 Cameron McCormack (:heycam) 2022-03-07 14:29:20 PST

Most of the above have already been fixed and removed from LayoutTests/gpu-process/TestExpectations.  Of the remaining:


accessibility/ios-simulator/aria-details.html [ Crash Pass ]
webkit.org/b/236794 editing/spelling/editing-word-with-marker-2.html [ Crash Pass ]

These two are hitting a release assert in TestInvocation::runUISideScriptImmediately.  Looks like we are calling a layer tree transaction callback, but by the time that happens, the test runner has moved on to a subsequent test.

This assertion is hit in non-gpuprocess config too.


ddcss3/images/cross-fade-simple.html [ Crash Pass ]

A typo, but cross-fade-simple.html used to crash and no longer does.


imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html [ Crash Pass ]
imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html [ Crash Pass ]
imported/w3c/web-platform-tests/webstorage/storage_session_window_open.window.html [ Crash Pass ]

Logs say that the GPU process crashed, but there's no crash log or any other information about what happened.  Interesting that these are all tests opening windows.

Comment 4 Cameron McCormack (:heycam) 2022-03-09 13:56:43 PST

Created attachment 454280 [details]
Patch

Comment 5 Cameron McCormack (:heycam) 2022-03-09 14:01:58 PST

Filed bug 237674 for the window opener crashes.

Comment 6 EWS 2022-03-09 19:19:26 PST

Committed r291086 (248248@main): <https://commits.webkit.org/248248@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454280 [details].