| Summary: | [WebGPU] Tracer bullet part 10: Implement setLabel() and Metal accessors | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | WebGPU | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, rmorisset, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 236879 | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2022-02-19 21:39:28 PST
Created attachment 452678 [details]
Patch
Comment on attachment 452678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452678&action=review > Source/WebGPU/WebGPU/RenderPassEncoder.mm:178 > + m_renderCommandEncoder.label = [NSString stringWithCString:label encoding:NSUTF8StringEncoding]; Do you ever want to ASSERT that m_renderCommandEncoder etc exist? Comment on attachment 452678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452678&action=review >> Source/WebGPU/WebGPU/RenderPassEncoder.mm:178 >> + m_renderCommandEncoder.label = [NSString stringWithCString:label encoding:NSUTF8StringEncoding]; > > Do you ever want to ASSERT that m_renderCommandEncoder etc exist? Yep! It's done in the creation routines. And rather than ASSERT()ing, it instead just doesn't create the WebGPU wrapper object. Committed r290266 (247591@trunk): <https://commits.webkit.org/247591@trunk> |