| Summary: | [WebGPU] Tracer bullet part 9: Basic implementation of bindings | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
| Component: | WebGPU | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, rmorisset, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 236879 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Myles C. Maxfield
2022-02-19 20:59:22 PST
Created attachment 452670 [details]
Patch
Created attachment 452671 [details]
Patch
Created attachment 452675 [details]
Patch
Comment on attachment 452675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452675&action=review > Source/WebGPU/WebGPU/BindGroup.h:48 > + id <MTLBuffer> vertexArgumentBuffer() const { return m_vertexArgumentBuffer; } > + id <MTLBuffer> fragmentArgumentBuffer() const { return m_fragmentArgumentBuffer; } > + id <MTLBuffer> computeArgumentBuffer() const { return m_computeArgumentBuffer; } id<MTLBuffer> no space. Here and elsewhere. Committed r290264 (?): <https://commits.webkit.org/r290264> Comment on attachment 452675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452675&action=review >> Source/WebGPU/WebGPU/BindGroup.h:48 >> + id <MTLBuffer> computeArgumentBuffer() const { return m_computeArgumentBuffer; } > > id<MTLBuffer> no space. Here and elsewhere. I sent an email to webkit-dev about this. Let's see what people say, and then I'll add a rule to the style guide about it. |