Bug 236840

Summary: [CSS Container Queries] Match container queries correctly in non-rendered subtrees
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229659    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing
none
Patch ews-feeder: commit-queue-

Description Antti Koivisto 2022-02-18 07:53:13 PST
"If the query container does not have a principal box ... then the result of evaluating the size feature is unknown."

https://drafts.csswg.org/css-contain-3/#size-container
Comment 1 Antti Koivisto 2022-02-18 08:04:42 PST
Created attachment 452521 [details]
Patch
Comment 2 Dean Jackson 2022-02-18 08:47:50 PST
Comment on attachment 452521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452521&action=review

> Source/WebCore/style/ContainerQueryEvaluator.cpp:180
> +    // If the query container does not have a principal box ... then the result of evaluating the size feature is unknown."

Nit: Either missing a leading " or maybe give the spec URL?
Comment 3 Antti Koivisto 2022-02-18 09:06:00 PST
Created attachment 452525 [details]
Patch for landing
Comment 4 Antti Koivisto 2022-02-18 10:49:40 PST
Created attachment 452543 [details]
Patch for landing
Comment 5 EWS 2022-02-18 13:21:16 PST
Patch 452543 does not build
Comment 6 Antti Koivisto 2022-02-18 22:17:47 PST
Created attachment 452627 [details]
Patch for landing
Comment 7 Antti Koivisto 2022-02-18 22:47:21 PST
Created attachment 452629 [details]
Patch
Comment 8 EWS 2022-02-19 06:07:08 PST
Committed r290205 (247533@main): <https://commits.webkit.org/247533@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452629 [details].
Comment 9 Radar WebKit Bug Importer 2022-02-19 06:08:16 PST
<rdar://problem/89186400>