| Summary: | [custom-effect] Animations associated with a custom effect should appear in document.getAnimations() result | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, dino, esprehn+autocc, ews-watchlist, graouts, kangil.han, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2022-02-18 00:17:47 PST
Created attachment 452492 [details]
Patch
Comment on attachment 452492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452492&action=review > LayoutTests/ChangeLog:9 > + * webanimations/custom-effect/custom-effect-get-animations-expected.txt: Added. > + * webanimations/custom-effect/custom-effect-get-animations.html: Added. Shouldn't this be in a WPT directory so we can contribute it back? What will track that effort? (In reply to Dean Jackson from comment #2) > Comment on attachment 452492 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452492&action=review > > > LayoutTests/ChangeLog:9 > > + * webanimations/custom-effect/custom-effect-get-animations-expected.txt: Added. > > + * webanimations/custom-effect/custom-effect-get-animations.html: Added. > > Shouldn't this be in a WPT directory so we can contribute it back? What will > track that effort? I'm writing all of those custom-effect tests with testharness so we may contribute them back, but I don't think we should upstream them until there are approved pull requests for the changes suggested. Committed r290122 (?): <https://commits.webkit.org/r290122> |