| Summary: | [macOS] Allow screen and window capture to be done in the GPU Process | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||
| Component: | WebRTC | Assignee: | Eric Carlson <eric.carlson> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Eric Carlson
2022-02-17 17:07:49 PST
Created attachment 452459 [details]
Patch
Comment on attachment 452459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452459&action=review r=me with a small nit, once the bots are green > Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:377 > + ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER); I think this can be ALWAYS_LOG_IF_POSSIBLE(LOGIDENTIFIER) > Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:403 > + ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER); Ditto Created attachment 452478 [details]
Patch
Created attachment 452508 [details]
[fast-cq] Patch for landing
Comment on attachment 452508 [details]
[fast-cq] Patch for landing
The windows failure is unrelated
Found 1 new test failure: fast/sandbox/mac/sandbox-mach-lookup.html Comment on attachment 452508 [details]
[fast-cq] Patch for landing
Per Arne and I can't see anything in this that could break fast/sandbox/mac/sandbox-mach-lookup.html
Committed r290174 (247505@main): <https://commits.webkit.org/247505@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452508 [details]. |