| Summary: | AX: isAXAuthenticatedCallback must be handled on the main runloop | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||
| Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andresg_22, cfleizach, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tyler Wilcock
2022-02-17 10:23:07 PST
Created attachment 452385 [details]
Patch
Comment on attachment 452385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452385&action=review > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:229 > + WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebProcessProxy::IsAXAuthenticated(auditToken), Messages::WebProcessProxy::IsAXAuthenticated::Reply(authenticated), 0); can we cache this? why do we need to keep checking this? (In reply to chris fleizach from comment #3) > Comment on attachment 452385 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452385&action=review > > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:229 > > + WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebProcessProxy::IsAXAuthenticated(auditToken), Messages::WebProcessProxy::IsAXAuthenticated::Reply(authenticated), 0); > > can we cache this? why do we need to keep checking this? It's requested very infrequently, once per AX client that tries to talk to the web process, so I don't think caching would be beneficial. Committed r290128 (247472@main): <https://commits.webkit.org/247472@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452385 [details]. |