| Summary: | [GTK] Build broken with ENABLE_X11_TARGET=OFF and no X11 headers present | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||||
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | alex, annulen, aperez, cgarcia, clopez, clord, dino, don.olmstead, ews-watchlist, gyuyoung.kim, kbr, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
There's the same issue in the 2.34.x releases, tested with the current state of the stable release branch. Created attachment 452350 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 452350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452350&action=review LGTM! Thanks! > Source/ThirdParty/ANGLE/ChangeLog:8 > + * PlatformGTK.cmake: The USE_SYSTEM_EGL definition makes detaches the type definitions I guess 'makes' is a leftover. (In reply to Alejandro G. Castro from comment #4) > Comment on attachment 452350 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452350&action=review > > LGTM! Thanks! > > > Source/ThirdParty/ANGLE/ChangeLog:8 > > + * PlatformGTK.cmake: The USE_SYSTEM_EGL definition makes detaches the type definitions > > I guess 'makes' is a leftover. Indeed it's a grammar mistake. I'll fix this before landing the patch, thanks! Created attachment 452363 [details]
Patch for landing
Committed r290027 (247407@main): <https://commits.webkit.org/247407@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452363 [details]. |
In file included from ../Source/ThirdParty/ANGLE/include/EGL/egl.h:39, from ../Source/ThirdParty/ANGLE/src/common/PackedEGLEnums_autogen.h, from ../Source/ThirdParty/ANGLE/src/common/PackedEnums.h:12, from ../Source/ThirdParty/ANGLE/src/common/PackedEnums.cpp:9: ../Source/ThirdParty/ANGLE/include/EGL/eglplatform.h:128:10: fatal error: X11/Xlib.h: No such file or directory 128 | #include <X11/Xlib.h> | ^~~~~~~~~~~~