Bug 236767

Summary: Multiple concurrency violations in LibWebRTCCodecsProxy
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebRTCAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, koivisto, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 236832    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Kimmo Kinnunen 2022-02-17 02:45:44 PST 
Multiple concurrency violations in LibWebRTCCodecsProxy
Comment 1 Kimmo Kinnunen 2022-02-17 02:59:06 PST 
<rdar://88904160>
Comment 2 Kimmo Kinnunen 2022-02-17 03:02:23 PST 
Created attachment 452342 [details]
Patch
Comment 3 Kimmo Kinnunen 2022-02-18 05:21:53 PST 
Created attachment 452512 [details]
Patch
Comment 4 Dean Jackson 2022-02-19 08:24:39 PST 
Comment on attachment 452512 [details]
Patch

Removing r? flag - it's already been reviewed by Antti. It looks like this is an EWS/landing test.
Comment 5 Kimmo Kinnunen 2022-02-24 03:24:30 PST 
Created attachment 453090 [details]
Patch for landing
Comment 6 Kimmo Kinnunen 2022-02-25 04:40:45 PST 
Created attachment 453197 [details]
Patch for landing
Comment 7 EWS 2022-02-26 00:14:06 PST 
Tools/Scripts/svn-apply failed to apply attachment 453197 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 8 Kimmo Kinnunen 2022-02-26 01:36:42 PST 
Created attachment 453289 [details]
Patch for landing
Comment 9 EWS 2022-02-26 04:09:21 PST 
Committed r290547 (?): <https://commits.webkit.org/r290547>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453289 [details].
Comment 10 youenn fablet 2022-03-01 07:25:24 PST 
Comment on attachment 453289 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=453289&action=review

> Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:281
> +        ASSERT_IS_TESTING_IPC();

This is a new ASSERT that is currently hit in bots, I'll fix it.
Comment 11 Kimmo Kinnunen 2022-03-03 01:53:14 PST 
(In reply to youenn fablet from comment #10)
> Comment on attachment 453289 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453289&action=review
> 
> > Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:281
> > +        ASSERT_IS_TESTING_IPC();
> 
> This is a new ASSERT that is currently hit in bots, I'll fix it.

Thanks, sorry for the trouble..