| Summary: | [WebGPU] Add a playground example target | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, rmorisset, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2022-02-16 17:11:23 PST
Created attachment 452274 [details]
Patch
Created attachment 452275 [details]
Patch
Comment on attachment 452275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452275&action=review > Source/WebGPU/CommandLinePlayground/main.swift:29 > +autoreleasepool { why does this have to be in an autoreleasepool? > Source/WebGPU/CommandLinePlayground/main.swift:36 > + var _ = WGPUTextureDescriptorViewFormats(chain: WGPUChainedStruct(next: nil, sType: WGPUSType(rawValue: WGPUSTypeExtended_TextureDescriptorViewFormats.rawValue)), viewFormatsCount: 0, viewFormats: nil) let? Comment on attachment 452275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452275&action=review >> Source/WebGPU/CommandLinePlayground/main.swift:29 >> +autoreleasepool { > > why does this have to be in an autoreleasepool? It doesn't. I'll delete it. >> Source/WebGPU/CommandLinePlayground/main.swift:36 >> + var _ = WGPUTextureDescriptorViewFormats(chain: WGPUChainedStruct(next: nil, sType: WGPUSType(rawValue: WGPUSTypeExtended_TextureDescriptorViewFormats.rawValue)), viewFormatsCount: 0, viewFormats: nil) > > let? Yep! Good catch. > Source/WebGPU/Configurations/CommandLinePlayground.xcconfig:24 > +PRODUCT_NAME = CommandLinePlayground; SWIFT_VERSION = 5.0; Committed r290069 (?): <https://commits.webkit.org/r290069> |