Bug 236732

Summary:

REGRESSION(r285885) Unable to exit Trip Details in Amtrak app

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, rbuis, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2022-02-16 14:28:25 PST

<rdar://87462825>

Comment 1 zalan 2022-02-16 15:08:31 PST

Created attachment 452252 [details]
Patch

Comment 2 zalan 2022-02-16 19:23:28 PST

@Rob, do you remember if there was any particular reason for adding this? I can't find anything related in the Changelog entry.

Comment 3 EWS 2022-02-16 20:24:49 PST

Committed r289995 (247381@main): <https://commits.webkit.org/247381@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452252 [details].

Comment 4 Rob Buis 2022-02-17 00:22:12 PST

(In reply to zalan from comment #2)
> @Rob, do you remember if there was any particular reason for adding this? I
> can't find anything related in the Changelog entry.

Not in particular, I made a judgment call on all overflowX/Y call sites and likely got this one wrong. Since this change has no regressions this part of the original patch was probably wrong.

Comment 5 zalan 2022-02-17 06:12:49 PST

(In reply to Rob Buis from comment #4)
> (In reply to zalan from comment #2)
> > @Rob, do you remember if there was any particular reason for adding this? I
> > can't find anything related in the Changelog entry.
> 
> Not in particular, I made a judgment call on all overflowX/Y call sites and
> likely got this one wrong. 
Thanks for confirming it.