| Summary: | [CSS Container Queries] Size queries on unsupported axis should evaluate to unknown | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 229659 | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2022-02-16 02:48:37 PST
Created attachment 452170 [details]
Patch
Comment on attachment 452170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452170&action=review > Source/WebCore/style/ContainerQueryEvaluator.cpp:203 > + if (axis == Axis::Width) > + axis = container.renderer.isHorizontalWritingMode() ? Axis::Inline : Axis::Block; > + else if (axis == Axis::Height) > + axis = container.renderer.isHorizontalWritingMode() ? Axis::Block : Axis::Inline; I guess this is only needed in the ::InlineSize case - maybe it could go there? I don't have strong opinions. > I guess this is only needed in the ::InlineSize case - maybe it could go
> there? I don't have strong opinions.
Good point!
Created attachment 452186 [details]
Patch for landing
Committed r289890 (247328@main): <https://commits.webkit.org/247328@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452186 [details]. |