Bug 236686

Summary:

Defer TerminationsExceptions while in operationMaterializeObjectInOSR.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	saam: review+

Description Mark Lam 2022-02-15 20:14:27 PST

operationMaterializeObjectInOSR expects to always succeed.  It is difficult (and not worth the effort) to make it be able to handle interruptions by the TerminationException.  Since operationMaterializeObjectInOSR is guaranteed to finish running in some finite time, it is reasonable to just defer handling a pending TerminationException until the function returns.

rdar://81337114

Comment 1 Mark Lam 2022-02-15 20:21:25 PST

Created attachment 452128 [details]
proposed patch.

Comment 2 Mark Lam 2022-02-15 22:13:01 PST

Thanks for the review.  Landed in r289877: <http://trac.webkit.org/r289877>.