Bug 236663

Summary: [WebKitLegacy] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2022-02-15 13:02:39 PST 
Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in WebKitLegacy.

Found by clang static analyzer.

Only one issue remaining after WTF fixes in Source/WebKitLegacy/mac/Misc/WebDownload.mm.
Comment 1 Radar WebKit Bug Importer 2022-02-15 13:02:54 PST 
<rdar://problem/88982792>
Comment 2 David Kilzer (:ddkilzer) 2022-02-15 13:52:24 PST 
Created attachment 452088 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2022-02-16 07:36:11 PST 
Comment on attachment 452088 [details]
Patch v1

Adding cq+ since mac-wk1 tests passed.
Comment 4 EWS 2022-02-16 10:22:25 PST 
Committed r289909 (247339@main): <https://commits.webkit.org/247339@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452088 [details].