Bug 236574

Summary:

[GPU Process] CSSFilter should be created only at the painting time

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

Layout and Rendering

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, kondapallykalyan, pdr, schenney, sergio, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

236573

Attachments:

Description	Flags
Patch	none
Patch	simon.fraser: review+, ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Said Abou-Hallawa

Reported 2022-02-13 16:21:21 PST

CSSFilter::create() is called twice: (1) while doing the layout and creating the page layers. This call is mainly for calculating the filter outsets which is used for layer clipping. In this case we do not have a GraphicsContext (2) while painting in RenderLayerFilters::beginFilterEffect(). In this case we do have a GraphicsContext Building whole filter chain just to calculate the filter outsets is wrong. Instead we can use the FilterOperation and SVGFilterPrimitiveStandardAttributes superclasses to get their outsets without having to build the FilterEffects.

Attachments
Patch (37.92 KB, patch) 2022-02-13 16:50 PST, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (37.12 KB, patch) 2022-02-13 21:04 PST, Said Abou-Hallawa	simon.fraser: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (63.05 KB, patch) 2022-03-28 14:22 PDT, Said Abou-Hallawa	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (64.02 KB, patch) 2022-03-28 16:09 PDT, Said Abou-Hallawa	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (64.38 KB, patch) 2022-03-29 00:16 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Patch (65.75 KB, patch) 2022-04-04 14:00 PDT, Said Abou-Hallawa	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Said Abou-Hallawa

Comment 1 2022-02-13 16:50:44 PST

Created attachment 451846 [details] Patch

Said Abou-Hallawa

Comment 2 2022-02-13 21:04:46 PST

Created attachment 451858 [details] Patch

Simon Fraser (smfr)

Comment 3 2022-02-14 13:16:06 PST

Comment on attachment 451858 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451858&action=review > Source/WebCore/rendering/RenderLayerFilters.h:77 > + RenderingMode m_renderingMode; Let's default-initialize this.

Radar WebKit Bug Importer

Comment 4 2022-02-20 16:22:17 PST

<rdar://problem/89210004>

Said Abou-Hallawa

Comment 5 2022-03-28 14:22:33 PDT

Created attachment 455955 [details] Patch

Said Abou-Hallawa

Comment 6 2022-03-28 16:09:17 PDT

Created attachment 455965 [details] Patch

Said Abou-Hallawa

Comment 7 2022-03-29 00:16:34 PDT

Created attachment 456001 [details] Patch