Bug 235746

Summary: Roll ANGLE to Feb 18 2022 (78c64dd74ee5)
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: ANGLEAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ashley, bfulgham, dino, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=237006
Bug Depends on:    
Bug Blocks: 238171    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch for landing none

Kyle Piddington
Reported 2022-01-27 17:07:19 PST
Roll ANGLE to Jan 27 2022 (c4a9d4169)
Attachments
Patch (4.50 MB, patch)
2022-01-27 18:09 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (5.70 MB, patch)
2022-02-18 13:28 PST, Kyle Piddington 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.70 MB, patch)
2022-02-18 14:30 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (5.70 MB, patch)
2022-02-23 15:54 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.70 MB, patch)
2022-02-24 16:23 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2022-01-27 18:09:00 PST
Created attachment 450198 [details] Patch
EWS Watchlist
Comment 2 2022-01-27 18:11:08 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Radar WebKit Bug Importer
Comment 3 2022-02-03 17:08:20 PST
<rdar://problem/88464021>
Kyle Piddington
Comment 4 2022-02-18 13:28:42 PST
Created attachment 452573 [details] Patch
Kyle Piddington
Comment 5 2022-02-18 14:30:23 PST
Created attachment 452582 [details] Patch
Kenneth Russell
Comment 6 2022-02-18 18:38:35 PST
Comment on attachment 452582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452582&action=review Looks great - I reviewed changes.diff and all the updates to src/libANGLE/renderer/metal/ . This roll will surely fix a lot of content in Safari. I defer to Dean's earlier review, though. > Source/ThirdParty/ANGLE/changes.diff:263 > +diff --git a/src/libANGLE/Context.cpp b/src/libANGLE/Context.cpp We need to upstream this bug fix in anglebug.com/6920 . > Source/ThirdParty/ANGLE/changes.diff:317 > +diff --git a/src/libANGLE/Surface.cpp b/src/libANGLE/Surface.cpp Same for this memory leak fix - also part of https://webkit.org/b/235284 - to anglebug.com/6920 . > Source/ThirdParty/ANGLE/changes.diff:512 > ++ // FIXME: Check that the format matches this IOSurface plane for pixel formats that we know of. Need to track this fix in WebKit and figure out what to do upstream, too. > Source/ThirdParty/ANGLE/changes.diff:818 > + size_t mEstimatedByteSize = 0; It's subtle but it looks like this diff is actually caused by the introduction in WebKit of std::enable_shared_from_this below. We should upstream these diffs.
Kenneth Russell
Comment 7 2022-02-22 12:59:02 PST
In the EWS failures: http/wpt/push-api/onpush-disabled.html is unrelated webgl/1.0.3/conformance/extensions/webgl-compressed-texture-pvrtc.html on the iOS Simulator is producing an error in the GPU process: -[MTLSerializerBlitCommandEncoder copyFromBuffer:sourceOffset:sourceBytesPerRow:sourceBytesPerImage:sourceSize:toTexture:destinationSlice:destinationLevel:destinationOrigin:options:]_block_invoke:465: failed assertion `Error creating pipeline state Error Domain=CompilerError Code=2 "Compiler encountered an internal error" UserInfo={NSLocalizedDescription=Compiler encountered an internal error} from pvrtc2' There were a few changes to compressed texture support in this ANGLE roll which might have affected the PVRTC format.
Kyle Piddington
Comment 8 2022-02-23 15:54:27 PST
Created attachment 453039 [details] Patch
Kyle Piddington
Comment 9 2022-02-23 16:00:40 PST
Rolled back PVRTC support in the sim. This isn't a regression, as we had these unsupported before. It would be nice to get PVRTC working, but not as part of a roll.
Kenneth Russell
Comment 10 2022-02-23 16:34:01 PST
Comment on attachment 453039 [details] Patch Looks good to me to remove the PVRTC formats from the iOS simulator. These weren't working the last time I tested them. Dean reviewed this earlier, so please feel free to use "Reviewed by Dean Jackson.".
Kyle Piddington
Comment 11 2022-02-24 16:23:09 PST
Created attachment 453151 [details] Patch for landing
EWS
Comment 12 2022-02-24 17:42:17 PST
Committed r290479 (247776@main): <https://commits.webkit.org/247776@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453151 [details].
Brent Fulgham
Comment 13 2022-05-26 14:49:29 PDT
This fix shipped with Safari 15.5 (all platforms).
Note You need to log in before you can comment on or make changes to this bug.