Bug 235467

Summary: [GPU Process] Add the class 'SourceImage' to represent variants of image
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, dino, ews-watchlist, fmalita, gyuyoung.kim, heycam, kondapallykalyan, pdr, ryuan.choi, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232411    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
heycam: review+
Patch none

Said Abou-Hallawa
Reported 2022-01-21 20:02:04 PST
FEImage has already an std::variant named 'SourceImage' to represent variants of image. The Pattern needs a similar structure; see bug 232411. So the plan is replace FEImage::SourceImage with the new class. Then make bug 232411 uses it as well.
Attachments
Patch (35.75 KB, patch)
2022-01-21 20:34 PST, Said Abou-Hallawa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (35.93 KB, patch)
2022-01-21 20:48 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (38.51 KB, patch)
2022-01-21 21:57 PST, Said Abou-Hallawa 		heycam: review+
DetailsFormatted DiffDiff
Patch (38.50 KB, patch)
2022-01-22 02:09 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2022-01-21 20:34:58 PST
Created attachment 449719 [details] Patch
Said Abou-Hallawa
Comment 2 2022-01-21 20:48:25 PST
Created attachment 449720 [details] Patch
Said Abou-Hallawa
Comment 3 2022-01-21 21:57:40 PST
Created attachment 449722 [details] Patch
Cameron McCormack (:heycam)
Comment 4 2022-01-21 23:34:56 PST
Comment on attachment 449722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449722&action=review > Source/WebCore/ChangeLog:8 > + Before the existence of GPUProces we used to make some drawing on an "GPUProcess" s/make some drawing/do some drawing/ > Source/WebCore/ChangeLog:10 > + NativeImage. With GPUProces, this will require bouncing the NativeImage "GPUProcess" > Source/WebCore/ChangeLog:11 > + between WebPorcess and GPUProcess at least two times. To make this scenario "WebProcess" > Source/WebCore/ChangeLog:12 > + efficient, a new class called SourceImage' will be introduced. The purpose Stray (or missing) apostrophe. > Source/WebCore/platform/graphics/SourceImage.cpp:74 > + auto imageBuffer = ImageBuffer::create(nativeImage->size(), RenderingMode::Unaccelerated, 1, DestinationColorSpace::SRGB(), PixelFormat::BGRA8); If canvas patterns will use this class, then they'll need a way to specify the color space when creating the ImageBuffer, so that we don't always convert to sRGB.
Said Abou-Hallawa
Comment 5 2022-01-22 02:09:14 PST
Created attachment 449728 [details] Patch
EWS
Comment 6 2022-01-22 17:04:48 PST
Committed r288412 (246303@main): <https://commits.webkit.org/246303@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449728 [details].
Radar WebKit Bug Importer
Comment 7 2022-01-22 17:05:26 PST
<rdar://problem/87931919>
Note You need to log in before you can comment on or make changes to this bug.