Bug 234240

Summary: GraphicsContextGLCocoa is missing a test to test all video texture upload pixel buffer formats
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: NEW    
Severity: Normal CC: dino, eric.carlson, ews-watchlist, glenn, jer.noble, kbr, kkinnunen, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 232235    
Bug Blocks:    
Attachments:
Description Flags
Patch dino: review+, ews-feeder: commit-queue-

Kimmo Kinnunen
Reported 2021-12-13 06:00:55 PST
GraphicsContextGLCocoa is missing a test to test all video texture upload pixel buffer formats This is a typical regression point
Attachments
Patch (12.85 KB, patch)
2021-12-13 06:05 PST, Kimmo Kinnunen 		dino: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-12-13 06:05:35 PST
Created attachment 446996 [details] Patch
Dean Jackson
Comment 2 2021-12-13 11:05:11 PST
Comment on attachment 446996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446996&action=review > Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm:298 > + auto status = WebCore::CVPixelBufferCreate(kCFAllocatorDefault, 72, 128, pixelFormat, pixelBufferAttributes, &pixelBufferRef); Maybe explain where the 72 x 128 comes from? I guess that's the size of the fake video :)
Radar WebKit Bug Importer
Comment 3 2021-12-20 06:01:16 PST
<rdar://problem/86721110>
Note You need to log in before you can comment on or make changes to this bug.