Bug 234022

Summary: Prepare for transition to C++20
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, japhet, jer.noble, keith_miller, kondapallykalyan, mark.lam, mmaxfield, msaboff, pdr, philipj, saam, sergio, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233963
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2021-12-08 11:31:16 PST
Prepare for transition to C++20
Attachments
Patch (92.48 KB, patch)
2021-12-08 11:38 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (87.38 KB, patch)
2021-12-08 16:40 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (86.73 KB, patch)
2021-12-09 15:11 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-12-08 11:38:49 PST
Created attachment 446397 [details] Patch
Alex Christensen
Comment 2 2021-12-08 16:40:28 PST
Created attachment 446455 [details] Patch
Yusuke Suzuki
Comment 3 2021-12-09 14:38:28 PST
Comment on attachment 446455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446455&action=review r=me with one fix. > Tools/TestWebKitAPI/Tests/WTF/Expected.cpp:-297 > - NonCopyable(NonCopyable&&) = default; > - NonCopyable(const NonCopyable&) = delete; > - NonCopyable& operator=(const NonCopyable&) = delete; > - NonCopyable& operator=(NonCopyable&&) = default; We should use `WTF_MAKE_NONCOPYABLE` here to make it noncopyable.
Alex Christensen
Comment 4 2021-12-09 15:11:36 PST
Created attachment 446618 [details] Patch
Alex Christensen
Comment 5 2021-12-09 15:47:49 PST
Comment on attachment 446618 [details] Patch For some reason that didn't compile. I removed that change from this patch.
Alex Christensen
Comment 6 2021-12-09 16:25:36 PST
http://trac.webkit.org/r286816
Radar WebKit Bug Importer
Comment 7 2021-12-09 16:26:22 PST
<rdar://problem/86296640>
Note You need to log in before you can comment on or make changes to this bug.