Bug 233836

Summary: REGRESSION(r285210)[GLIB][GStreamer] http/tests/media/media-blocked-by-willsendrequest.html is timing out
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: MediaAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cdumez, cgarcia, changseok, dpino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232195
Attachments:
Description Flags
Tentative patch
ews-feeder: commit-queue-
Updated patch fixing the directive calvaris: review+, ews-feeder: commit-queue-

Lauro Moura
Reported 2021-12-03 12:13:31 PST
http/tests/media/media-blocked-by-willsendrequest.html Locally it was crashing alongside other WPT failures due to bug232629, but given a workaround for the crash was landed recently, now its timeout can be properly investigated/tracked. Looks like r285210 removed a check that was supposed to affect only Cocoa but it made Soup-based ports to fail too. Patch incoming.
Attachments
Tentative patch (1.73 KB, patch)
2021-12-03 17:27 PST, Lauro Moura 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Updated patch fixing the directive (1.70 KB, patch)
2021-12-03 19:59 PST, Lauro Moura 		calvaris: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2021-12-03 17:27:47 PST
Created attachment 445932 [details] Tentative patch
Lauro Moura
Comment 2 2021-12-03 19:59:33 PST
Created attachment 445946 [details] Updated patch fixing the directive
Lauro Moura
Comment 3 2021-12-05 18:11:44 PST
In the GTK EWS it caught this regression: imported/w3c/web-platform-tests/content-security-policy/media-src/media-src-redir-bug.sub.html --- /home/lauro/dev/WebKit/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/media-src/media-src-redir-bug.sub-expected.txt +++ /home/lauro/dev/WebKit/layout-test-results/imported/w3c/web-platform-tests/content-security-policy/media-src/media-src-redir-bug.sub-actual.txt @@ -7,9 +7,9 @@ Harness Error (TIMEOUT), message = null -NOTRUN In-policy async video src +FAIL In-policy async video src assert_unreached: Media error handler shouldn't be triggered for allowed domain. Reached unreachable code NOTRUN in-policy async video src w/redir -NOTRUN In-policy async video source element +FAIL In-policy async video source element assert_unreached: Media error handler shouldn't be triggered for allowed domain. Reached unreachable code NOTRUN In-policy async video source element w/redir NOTRUN Should not fire policy violation events This test tests a buggy interaction in Chrome 46. Two hosts (self and www2) are both allowed as media-src, but only one (self) is allowed for connect-src. If a video src starts on an allowed host (self), and is redirected to another allowed media-src host, it should succeed. But a bug causes the redirect to be done in a fetch context to which connect-src is being applied instead, so the load is blocked. (This test passes in Firefox 45, modulo an event listener not firing.)
Diego Pino
Comment 4 2023-02-01 03:53:57 PST
This test has been consistenly passing for many revisions now: https://results.webkit.org/?suite=layout-tests&test=imported/w3c/web-platform-tests/dom/xslt/strip-space-crash.xml&platform=GTK&platform=WPE&platform=mac&platform=ios Removed test from TestExpectations in https://commits.webkit.org/259674@main. Closing bug.
Radar WebKit Bug Importer
Comment 5 2023-02-01 03:54:26 PST
<rdar://problem/104909851>
Note You need to log in before you can comment on or make changes to this bug.