Bug 233424

Summary: [JSC] Unify most Baseline ops between JSVALUE64 and JSVALUE32_64
Product: WebKit Reporter: Geza Lore <glore>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, xan.lopez, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Fix nit none

Geza Lore
Reported 2021-11-22 07:28:02 PST
[JSC] Unify most Baseline ops between JSVALUE64 and JSVALUE32_64
Attachments
Patch (146.07 KB, patch)
2021-11-22 08:26 PST, Geza Lore 		no flags
DetailsFormatted DiffDiff
Patch (145.10 KB, patch)
2021-11-22 09:51 PST, Geza Lore 		no flags
DetailsFormatted DiffDiff
Patch (145.10 KB, patch)
2021-11-23 02:16 PST, Geza Lore 		no flags
DetailsFormatted DiffDiff
Patch (145.10 KB, patch)
2021-11-24 05:51 PST, Geza Lore 		no flags
DetailsFormatted DiffDiff
Fix nit (145.14 KB, patch)
2021-11-30 02:40 PST, Geza Lore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Geza Lore
Comment 1 2021-11-22 08:26:11 PST
Created attachment 444968 [details] Patch
Geza Lore
Comment 2 2021-11-22 09:51:49 PST
Created attachment 444975 [details] Patch
Geza Lore
Comment 3 2021-11-23 02:16:32 PST
Created attachment 445019 [details] Patch
Geza Lore
Comment 4 2021-11-24 05:51:29 PST
Created attachment 445093 [details] Patch
Radar WebKit Bug Importer
Comment 5 2021-11-29 07:28:19 PST
<rdar://problem/85815818>
Yusuke Suzuki
Comment 6 2021-11-29 13:00:43 PST
Comment on attachment 445093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445093&action=review r=me > Source/JavaScriptCore/jit/JIT.h:336 > + static inline constexpr bool is_profiled_op = std::is_same_v<decltype(Op::Metadata::m_profile), ValueProfile>; Rename it to isProfiledOp.
Geza Lore
Comment 7 2021-11-30 02:40:48 PST
Created attachment 445401 [details] Fix nit
EWS
Comment 8 2021-11-30 07:44:33 PST
Committed r286296 (244655@main): <https://commits.webkit.org/244655@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445401 [details].
Note You need to log in before you can comment on or make changes to this bug.