Bug 233092

Summary: [GTK] Implement UIScriptController sendEventStream for wheel events
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Chris Lord <clord>
Status: NEW    
Severity: Normal CC: bdakin, berto, cgarcia, clord, csaavedra, ews-watchlist, gustavo, mcatanzaro, pnormand, simon.fraser, thorton
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=244186
Attachments:
Description Flags
Patch clord: review?

Simon Fraser (smfr)
Reported 2021-11-13 14:58:11 PST
I'm starting to convert tests that use eventSender.mouseScrollByWithWheelAndMomentumPhases() to UIScriptController.sendEventStream, so it would be good if GTK implemented this. See http://trac.webkit.org/r285390
Attachments
Patch (18.74 KB, patch)
2022-01-06 03:03 PST, Chris Lord 		clord: review?
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2022-01-06 03:03:44 PST
Created attachment 448483 [details] Patch
EWS Watchlist
Comment 2 2022-01-06 03:05:21 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Chris Lord
Comment 3 2022-01-06 03:06:31 PST
As far as I know there are no tests using sendEventStream that aren't specific to iOS at the moment, so this is basically untested. Attaching the patch so this can be picked up later when there are some tests with which to test it. It shouldn't take much adaptation to do the equivalent for WPE, it might be good to share the JSON parsing in UIScriptControllerGtk when that happens.
Claudio Saavedra
Comment 4 2023-05-29 06:02:09 PDT
Skipping imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html?touch in https://github.com/WebKit/WebKit/pull/14452 , as the test crashes due to missing sendEventStream in both GTK and WPE. Would be good to revisit this patch and land.
Note You need to log in before you can comment on or make changes to this bug.