Bug 232843

Summary: [GPU Process] [Filters 14/23] Apply the filter to an ImageBuffer through GraphicsContext and ImageBuffer
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, heycam, kondapallykalyan, macpherson, menard, pdr, ryuan.choi, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233611
Bug Depends on:    
Bug Blocks: 231253    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
heycam: review+
Patch none

Said Abou-Hallawa
Reported 2021-11-08 13:18:54 PST
This will make it possible to record applying the filter for GPUProcess.
Attachments
Patch (38.41 KB, patch)
2021-11-27 13:43 PST, Said Abou-Hallawa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (39.01 KB, patch)
2021-11-27 14:16 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (36.45 KB, patch)
2021-11-27 19:14 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (35.47 KB, patch)
2021-11-27 21:14 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (37.52 KB, patch)
2021-11-28 11:50 PST, Said Abou-Hallawa 		heycam: review+
DetailsFormatted DiffDiff
Patch (37.43 KB, patch)
2021-11-28 19:41 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-15 13:23:10 PST
<rdar://problem/85426291>
Said Abou-Hallawa
Comment 2 2021-11-27 13:43:08 PST
Created attachment 445223 [details] Patch
Said Abou-Hallawa
Comment 3 2021-11-27 14:16:50 PST
Created attachment 445224 [details] Patch
Said Abou-Hallawa
Comment 4 2021-11-27 19:14:35 PST
Created attachment 445228 [details] Patch
Said Abou-Hallawa
Comment 5 2021-11-27 21:14:32 PST
Created attachment 445231 [details] Patch
Said Abou-Hallawa
Comment 6 2021-11-28 11:50:02 PST
Created attachment 445240 [details] Patch
Said Abou-Hallawa
Comment 7 2021-11-28 19:41:03 PST
Created attachment 445247 [details] Patch
Said Abou-Hallawa
Comment 8 2021-11-28 19:53:51 PST
Comment on attachment 445240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445240&action=review > Source/WebCore/rendering/CSSFilter.cpp:401 > + effect->transformResultColorSpace(DestinationColorSpace::SRGB()); This call is not needed since the caller which is Filter::apply() will transform the returned FilterImage to sRGB. This is fixed in the latest patch.
EWS
Comment 9 2021-11-28 22:08:34 PST
Committed r286203 (244585@main): <https://commits.webkit.org/244585@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445247 [details].
Note You need to log in before you can comment on or make changes to this bug.