Bug 23019

Summary: The embed element is still not hidden by display:none
Product: WebKit Reporter: wesleyZeng <weihong.zeng>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Testcase none

wesleyZeng
Reported 2008-12-28 20:48:46 PST
As follow: <embed id="fc" src="http://801.tianya.cn/2008/12/sanguo/1224/640.swf"></embed> <script> var obj = document.getElementById("fc"); obj.style.display ="none"; </script> If the display equals to "none", rendererIsNeeded should return false. bool HTMLEmbedElement::rendererIsNeeded(RenderStyle* style) { if (isImageType()) return HTMLPlugInElement::rendererIsNeeded(style); Frame* frame = document()->frame(); if (!frame) return false; Node* p = parentNode(); if (p && p->hasTagName(objectTag)) { ASSERT(p->renderer()); return false; } - return true; + return HTMLElement::rendererIsNeeded(style); }
Attachments
Testcase (652 bytes, text/html)
2009-02-24 21:30 PST, Simon Fraser (smfr)
no flags
Simon Fraser (smfr)
Comment 1 2009-02-24 21:30:45 PST
Created attachment 27957 [details] Testcase
Simon Fraser (smfr)
Comment 2 2009-02-24 22:08:56 PST
*** This bug has been marked as a duplicate of 15081 ***
Note You need to log in before you can comment on or make changes to this bug.