Bug 229903

Summary: Clean up some mask-related properties in CSSProperties.json
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED WONTFIX    
Severity: Normal CC: darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, macpherson, menard, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229082    
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Simon Fraser (smfr)
Reported 2021-09-03 16:04:56 PDT
Clean up some mask-related properties in CSSProperties.json
Attachments
Patch (6.81 KB, patch)
2021-09-03 16:07 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-09-03 16:07:26 PDT
Created attachment 437321 [details] Patch
Darin Adler
Comment 2 2021-09-03 16:46:07 PDT
Comment on attachment 437321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437321&action=review > Source/WebCore/ChangeLog:10 > + Remove "status": "experimental" from a bunch of mask-related properties, since they are no longer > + experimental. Mark -webkit-mask-position-x and -webkit-mask-position-y as internal-only, since they don't > + appear in the css-masking spec. Fix some formatting issues. What does it mean to mark -webkit-mask-position-x as internal only? Does it mean the property won’t be exposed to websites?
Simon Fraser (smfr)
Comment 3 2021-09-03 17:09:38 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 437321 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=437321&action=review > > > Source/WebCore/ChangeLog:10 > > + Remove "status": "experimental" from a bunch of mask-related properties, since they are no longer > > + experimental. Mark -webkit-mask-position-x and -webkit-mask-position-y as internal-only, since they don't > > + appear in the css-masking spec. Fix some formatting issues. > > What does it mean to mark -webkit-mask-position-x as internal only? Does it > mean the property won’t be exposed to websites? It means that they don't appear in computed style or style properties, and they don't parse.
Simon Fraser (smfr)
Comment 4 2021-09-03 17:13:35 PDT
It's possible that this is not web compatible. https://www.chromestatus.com/metrics/css/popularity says that -webkit-mask-position-x is used on 0.093755% of page loads. I may have to only make the unprefixed versions internal.
Note You need to log in before you can comment on or make changes to this bug.