Bug 228808

Summary: Change WebSocket.cpp to @no-unify, since it’s hard to do that for someone without a Mac
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 226557    
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2021-08-04 18:15:51 PDT
Michael Catanzaro asked for help making WebSocket.cpp a @no-unify file, including the Xcode project changes.
Attachments
Patch (3.38 KB, patch)
2021-08-04 18:18 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2021-08-04 18:18:26 PDT
Created attachment 434960 [details] Patch
Darin Adler
Comment 2 2021-08-04 18:20:31 PDT
Not thrilled to be adding more @no-unify. We’d like to do the reverse and have fewer separately compiled files!
EWS
Comment 3 2021-08-04 19:52:07 PDT
Committed r280677 (240279@main): <https://commits.webkit.org/240279@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434960 [details].
Radar WebKit Bug Importer
Comment 4 2021-08-04 19:53:18 PDT
<rdar://problem/81546248>
Michael Catanzaro
Comment 5 2021-08-05 06:43:07 PDT
Thanks Darin! (In reply to Darin Adler from comment #2) > Not thrilled to be adding more @no-unify. We’d like to do the reverse and > have fewer separately compiled files! I know. :/ I've tried my best in bug #226557 and concluded it's either do this, or build all of WebCore with -Wno-stringop-overread. I'd rather suppress it for this one file than the entire project.
Note You need to log in before you can comment on or make changes to this bug.