Bug 227008

Summary: [SOUP] Add Timing-Allow-Origin checks to NetworkDataTaskSoup
Product: WebKit Reporter: Arcady Goldmints-Orlov <crzwdjk>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cgarcia, dpino, webkit-bug-importer
Priority: P2 Keywords: InRadar, Soup
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226678
Attachments:
Description Flags
Patch
none
Patch aperez: review+

Arcady Goldmints-Orlov
Reported 2021-06-14 20:05:04 PDT
Bug 226678 moved Timing-Allow-Origin checks to the network process on cocoa but did not do so for soup. It also added a number of web platform tests for Timing-Allow-Origin that fail on Linux. NetworkDataTaskSoup::continueHTTPRedirection() needs to add the checks as mentioned in the FIXME comment in that method.
Attachments
Patch (2.91 KB, patch)
2021-06-15 18:37 PDT, Arcady Goldmints-Orlov 		no flags
DetailsFormatted DiffDiff
Patch (10.61 KB, patch)
2021-06-17 02:18 PDT, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Arcady Goldmints-Orlov
Comment 1 2021-06-15 18:37:06 PDT
Created attachment 431508 [details] Patch
EWS
Comment 2 2021-06-16 01:11:25 PDT
Committed r278924 (238855@main): <https://commits.webkit.org/238855@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431508 [details].
Radar WebKit Bug Importer
Comment 3 2021-06-16 01:12:18 PDT
<rdar://problem/79384792>
Arcady Goldmints-Orlov
Comment 4 2021-06-16 08:55:37 PDT
Reopening to track the fix.
Carlos Garcia Campos
Comment 5 2021-06-17 02:18:29 PDT
Created attachment 431639 [details] Patch
Carlos Garcia Campos
Comment 6 2021-06-18 01:05:35 PDT
Committed r279032 (238952@main): <https://commits.webkit.org/238952@main>
Note You need to log in before you can comment on or make changes to this bug.