Bug 226627

Summary: [GTK] Support color-scheme
Product: WebKit Reporter: Milan Crha <mcrha>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: alicem, bugs-noreply, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
a.html none

Milan Crha
Reported 2021-06-03 23:20:13 PDT
Created attachment 430550 [details] a.html Coming from a downstream bug report: https://gitlab.gnome.org/GNOME/evolution/-/issues/1522 There are cases where form elements should be better drawn with the theme color, rather than "always light theme". Michael also pointer to bug #197947 there. Reproducer: a) get the attached a.html b) execute: GTK_THEME=Adwaita-dark /usr/libexec/webkit2gtk-4.0/MiniBrowser /tmp/a.html the buttons (and the content) is in the light theme, even it would be better in the dark theme. At least the buttons. I also tried to set content="dark" in the <meta>, but it didn't change anything (I thought it'll force the dark theme). This is with webkit2gtk3-2.32.1-1.fc34.x86_64.
Attachments
a.html (152 bytes, text/html)
2021-06-03 23:20 PDT, Milan Crha 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2021-06-04 06:38:59 PDT
Basically in bug #197947 we made normal web content that doesn't know about dark mode work properly, and we made web content that uses only prefers-color-scheme work properly. But we don't support color-scheme at all. I think that's HAVE(OS_DARK_MODE_SUPPORT) which was disabled in bug #197947. We probably want to bring that back.
Alice Mikhaylenko
Comment 2 2021-07-09 04:16:33 PDT
Duplicate of https://bugs.webkit.org/show_bug.cgi?id=208204?
Michael Catanzaro
Comment 3 2021-07-09 05:01:20 PDT
Yes. *** This bug has been marked as a duplicate of bug 208204 ***
Note You need to log in before you can comment on or make changes to this bug.