Bug 226380

Summary: Hit-testing does not account for clip-path on <iframe>
Product: WebKit Reporter: Antoine Quint <graouts>
Component: Layout and RenderingAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 226499    
Attachments:
Description Flags
Patch
none
Patch
none
Patch koivisto: review+

Antoine Quint
Reported 2021-05-28 09:43:09 PDT
Hit-testing does not account for clip-path on <iframe>
Attachments
Patch (13.43 KB, patch)
2021-05-28 09:47 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (13.42 KB, patch)
2021-05-29 10:51 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (13.43 KB, patch)
2021-06-01 02:14 PDT, Antoine Quint 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-05-28 09:43:47 PDT
<rdar://problem/78621486>
Antoine Quint
Comment 2 2021-05-28 09:47:20 PDT
Created attachment 430021 [details] Patch
Antoine Quint
Comment 3 2021-05-28 09:47:26 PDT
<rdar://problem/78621486>
Antoine Quint
Comment 4 2021-05-29 10:51:06 PDT
Created attachment 430097 [details] Patch
Antoine Quint
Comment 5 2021-06-01 02:14:58 PDT
Created attachment 430241 [details] Patch
Antti Koivisto
Comment 6 2021-06-01 08:46:36 PDT
Comment on attachment 430241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430241&action=review > LayoutTests/css3/masking/clip-path-iframe.html:9 > + if (window.eventSender) > + eventSender.mouseMoveTo(50, 50); This won't work on iOS. It would be better if the test was constructed so that all platforms are covered (and nothing happens case wouldn't pass). You can exercise hit testing code directly in platform independent manner by using Document.elementFromPoint.
Antti Koivisto
Comment 7 2021-06-01 08:50:48 PDT
Comment on attachment 430241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430241&action=review > LayoutTests/css3/masking/clip-path-iframe.html:15 > +iframe { I think this also affects replaced elements like <img>. It would be good to have a test for them too.
Antoine Quint
Comment 8 2021-06-02 01:28:50 PDT
Committed r278343 (238375@main): <https://commits.webkit.org/238375@main>
Note You need to log in before you can comment on or make changes to this bug.